-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate project in separate directory, keep submodule dirs clean #77
Conversation
All intermediate build files are stored in "bin-int/". This is explicit to keep all output directories "bin" and "bin-int" in alphabetical order to make it easy to delete. |
I think there is no any reason to keep 'bin', 'bin-int' or any other generated files in submodules or in other subdirectories of repository. |
The argument of moving the bin and bin-int out of the submodules to keep A beter solution for this is to add the bin; bin-int and vs-files to the .gitignore of the submodules. This way it should ignore those and won't show up as untracked content. We did add bin and bin-int to the .gitignore while working on the linux support. Once we merge that all in, we could revisit this to add the VS files to it as well? |
The compiled objects in the submodules aren't relevant because they honestly don't need to be rebuilt. The hacking is done on Hazel itself. I'll give it that the file management is a little problematic since the Hazel repository puts premake files into the submodule directories! |
|
Should this have the label of "Awaiting Cherno's Approval"? Reason being is because I feel like removal of files or changing the directory requires an "executive" decision from him. Generally I think Cherno should give input on if he would want this or not, and if he wouldn't it could be closed. |
This requires the submodules to be merged first anyway... and only cherno can merge in submodules anyway... |
With #228 merged, the |
Changed the output directory for premake generated projects and obj files.
I think it is better to keep generated solution and intermediate binaries in the separated directory than in many other places in the repo.
The result is following directory tree:
─project
├───build
│ ├───bin
│ │ └───Debug-windows-x86_64
│ │ ├───Glad
│ │ ├───GLFW
│ │ ├───Hazel
│ │ ├───ImGui
│ │ └───Sandbox
│ └───bin-int
│ └───Debug-windows-x86_64
│ ├───Glad
│ ├───GLFW
│ ├───Hazel
│ ├───ImGui
│ └───Sandbox
├───Hazel
└───Sandbox
There are also requests for glfw and imgui submodules:
TheCherno/imgui#6
TheCherno/glfw#7