Request for review of project#400
Open
Kerem1989 wants to merge 8 commits intoTheCSharpAcademy:masterfrom
Open
Conversation
TheCSharpAcademy
requested changes
Apr 4, 2026
Owner
TheCSharpAcademy
left a comment
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@Kerem1989 Thanks for submitting! Apologies for the delay in the review 😟. There's a major bug in the app so I can't approve it. As you can see in the picture below, at the moment when I input a date it fails silently and just replaces it with the current date. Users need to know what's the expected format and if there's an error they we need to show a proper error message.
Also, every time the app starts it drops the database, which defeats the purpose of the database altogether.
Could you please fix so we can approve?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.