Fix false positives in secret/crypto/pii rules #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19. Aligns rule behavior with the normalized indexer metadata per OpenSpec change
fix-false-positive-rules.Key changes
hardcoded_secret_analyzenow inspects the literal metadata extracted by the indexer. Header-derived or other non-literal sources (e.g.,request.headers.get(...)) are no longer flagged assecret-hardcoded-assignment..includes()stop colliding with DES aliases (crypto-weak-encryptionfalse positives are gone).messageor strings likepackage.jsonno longer triggerpii-*alerts.tests/test_rules/test_false_positive_regressions.py) that reproduces the Lovaseo scenarios the customer reported.Validation
pytest tests/test_rules/test_false_positive_regressions.pysource /home/dev/projects/org/lovaseo/.auditor_venv/bin/activate && aud detect-patternsopenspec validate fix-false-positive-rules --strictOpenSpec change:
fix-false-positive-rules