Minor cleanup

TheArcaneBrony · May 31, 2024 · 65d6fa9 · 65d6fa9
1 parent 808f94b
commit 65d6fa9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/ArcaneLibs/Attributes/TableHideAttribute.cs b/ArcaneLibs/Attributes/TableHideAttribute.cs
@@ -1,6 +1,4 @@
-using System.Reflection;
-
 namespace ArcaneLibs.Attributes;
 
-[AttributeUsage(AttributeTargets.Class | AttributeTargets.Property, AllowMultiple = false)]
+[AttributeUsage(AttributeTargets.Class | AttributeTargets.Property)]
 public class TableHideAttribute : Attribute;
diff --git a/ArcaneLibs/Collections/ObservableDictionary.cs b/ArcaneLibs/Collections/ObservableDictionary.cs
@@ -16,7 +16,7 @@ public ObservableDictionary(ObservableDictionary<TKey, TValue> value) {
     }
 
     public event NotifyCollectionChangedEventHandler? CollectionChanged;
-    public event PropertyChangedEventHandler PropertyChanged;
+    public event PropertyChangedEventHandler? PropertyChanged;
 
     public int Count => _dictionary.Count;
     public bool IsReadOnly => false;
@@ -42,8 +42,7 @@ public void Add(TKey key, TValue value) {
     }
 
     public bool Remove(TKey key) {
-        if (!_dictionary.ContainsKey(key)) return false;
-        var value = _dictionary[key];
+        if (!_dictionary.TryGetValue(key, out var value)) return false;
         var result = _dictionary.Remove(key);
         if (result) {
             CollectionChanged?.Invoke(this, new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Remove, new KeyValuePair<TKey, TValue>(key, value)));

diff --git a/ArcaneLibs/Extensions/Streams/StreamExtensions.cs b/ArcaneLibs/Extensions/Streams/StreamExtensions.cs
@@ -127,7 +127,7 @@ public static IEnumerable<byte> ReadTerminatedField(this Stream stream, byte ter
                     $"Text prefix {stream.Peek(asciiPrefix.Length).AsHexString()} ({stream.Peek(asciiPrefix.Length).AsString()}) does not match expected value of {asciiPrefix.AsBytes().AsHexString()} ({asciiPrefix})!");
             else stream.Skip(asciiPrefix.Length);
 
-        var read = 0;
+        // var read = 0;
         while (stream.Peek() != terminator) {
             // if (_debug)
             //     Console.WriteLine(
@@ -137,7 +137,7 @@ public static IEnumerable<byte> ReadTerminatedField(this Stream stream, byte ter
                 yield break;
             }
 
-            read++;
+            // read++;
             yield return (byte)stream.ReadByte();
         }
 

diff --git a/ArcaneLibs/Util.cs b/ArcaneLibs/Util.cs
@@ -1,7 +1,5 @@
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
-using System.IO.Compression;
-using System.Net;
 
 namespace ArcaneLibs;