Fix Kahn's algorithm - #15074
Closed
Dharshini-RS03 wants to merge 1 commit into
Closed
Conversation
algorithms-keeper
Bot
added
enhancement
cclauss
requested changes
Sep 6, 2026
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
Please add a benchmark that proves that the proposed changes could save significant runtime.
algorithms-keeper
Bot
added
awaiting changes
cclauss
approved these changes
Sep 12, 2026
algorithms-keeper
Bot
removed
the
awaiting changes
Member
|
Git conflicts. Please rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixed Kahn’s algorithm to support sparse/non-contiguous vertex IDs.
Improved queue performance using
dequeand added doctests for sparse graphs.Add an algorithm?
Fix a bug or typo in an existing algorithm?
Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
Documentation change?
Checklist:
Fixes [BUG] Inefficient pop(0) queue operations and IndexError on sparse vertex IDs in graphs/kahns_algorithm_topo.py #15071