Skip to content

Fix Tree Sort algorithm for duplicate values and input types #12786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lighting9999
Copy link
Contributor

@lighting9999 lighting9999 commented Jun 7, 2025

Describe your change:

  1. Fixed duplicate value handling:

    • Modified BST insertion to accept values <= current node to left subtree
    • Ensures duplicate values appear in sorted order
  2. Enhanced input type support:

    • Function now accepts both lists and tuples as input
    • Added type annotation: arr: list[int] | tuple[int, ...]
  3. Improved empty input handling:

    • Returns empty tuple immediately for empty input
    • More efficient than building BST
  4. Added comprehensive documentation:

    • Complete docstring with examples and edge cases
    • Detailed comments explaining BST traversal and insertion
    • Explicit test case for duplicate values
  5. Optimized variable naming:

    • items = list(arr) for clarity
    • Removed unused len method
  6. Maintained all original functionality:

    • Still returns sorted tuple
    • Preserves BST sorting algorithm
    • Passes all original tests plus new tests for duplicates

All pre-commit checks pass:

  • ruff (linting and formatting)
  • mypy (type checking)
  • codespell (spelling)
  • doctests
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jun 7, 2025
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jun 7, 2025
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant