Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sphinx/build_docs warnings for ciphers #12485

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Fix sphinx/build_docs warnings for ciphers #12485

merged 2 commits into from
Dec 30, 2024

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Fix sphinx/build_docs warnings for ciphers

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Dec 30, 2024
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Dec 30, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Dec 30, 2024
@MaximSmolskiy
Copy link
Member Author

@cclauss please review

cclauss
cclauss approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and merge or close some of our ~300 PRs

@cclauss cclauss removed the awaiting reviews This PR is ready to be reviewed label Dec 30, 2024
@MaximSmolskiy MaximSmolskiy merged commit f45e392 into TheAlgorithms:master Dec 30, 2024
5 checks passed
@MaximSmolskiy MaximSmolskiy deleted the fix-sphinx/build_docs-warning-for-ciphers branch December 30, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximSmolskiy @cclauss