Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve comments and add tests to trapezoidal rule #11640

Merged
merged 12 commits into from
Dec 31, 2024
Merged

chore: improve comments and add tests to trapezoidal rule #11640

merged 12 commits into from
Dec 31, 2024

Conversation

jurichar
Copy link
Contributor

@jurichar jurichar commented Oct 1, 2024 •
edited
Loading

Describe your change:

Contributes to #9943
And convert value explicity to float

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 1, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 1, 2024
tianyizheng02
tianyizheng02 requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my other comments, this file also needs type hints

maths/trapezoidal_rule.py Outdated Show resolved Hide resolved
maths/trapezoidal_rule.py Outdated Show resolved Hide resolved
maths/trapezoidal_rule.py Outdated Show resolved Hide resolved
maths/trapezoidal_rule.py Outdated Show resolved Hide resolved
@tianyizheng02 tianyizheng02 added the require type hints https://docs.python.org/3/library/typing.html label Oct 4, 2024
@algorithms-keeper algorithms-keeper bot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 6, 2024
jurichar and others added 3 commits October 6, 2024 14:21
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 6, 2024
jurichar
jurichar commented Oct 6, 2024
View reviewed changes
Copy link
Contributor Author

@jurichar jurichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions seems tested and goodly commented

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 6, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Dec 31, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Dec 31, 2024
@tianyizheng02 tianyizheng02 merged commit a439902 into TheAlgorithms:master Dec 31, 2024
5 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurichar @tianyizheng02