-
Notifications
You must be signed in to change notification settings - Fork 20k
Add Boyer-Moore string search algorithm with JUnit tests #6274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6274 +/- ##
============================================
+ Coverage 74.07% 74.10% +0.03%
- Complexity 5351 5361 +10
============================================
Files 677 678 +1
Lines 18648 18673 +25
Branches 3621 3627 +6
============================================
+ Hits 13813 13838 +25
Misses 4276 4276
Partials 559 559 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi! The PR is ready, all checks are passing. Let me know if I need to implement changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good implementation for the bad character rule!
Thanks Deniz! I don't have write permissions, so could someone with access please merge it? |
yess, no hurry @PauLopNun :) . @siriak will do it after he reviewed. |
Okay 👍🏼, this is one of my first times contributing to open source, so I'm still getting used to the review process. |
clang-format -i --style=file path/to/your/file.java