-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Absolute value Algorithm #462
Feature: Absolute value Algorithm #462
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 94.92% 94.94% +0.01%
==========================================
Files 237 238 +1
Lines 10058 10091 +33
Branches 1422 1429 +7
==========================================
+ Hits 9548 9581 +33
Misses 392 392
Partials 118 118 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but you need to improve coverage with tests, see Codacy report
Thank you for your review! I believe my latest commits should address the test coverage issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Summary of the Change:
This pull request introduces the Absolute algorithm, a simple and efficient way to calculate the absolute value of a number in C#.
Motivation:
I wanted to make my first Open Source contribution and noticed that the Absolute algorithm was implemented in other programming languages but not in C#, so I wanted to add this functionality to the project.