Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Absolute value Algorithm #462

Merged

Conversation

RicardoRibeiroRodrigues
Copy link
Contributor

Summary of the Change:
This pull request introduces the Absolute algorithm, a simple and efficient way to calculate the absolute value of a number in C#.

Motivation:
I wanted to make my first Open Source contribution and noticed that the Absolute algorithm was implemented in other programming languages but not in C#, so I wanted to add this functionality to the project.

  • [ X ] I have performed a self-review of my code
  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have added tests that prove my fix is effective or that my feature works
  • [ X ] New and existing unit tests pass locally with my changes
  • [ X ] Comments in areas I changed are up to date
  • [ X ] I have added comments to hard-to-understand areas of my code
  • [ X ] I have made corresponding changes to the README.md

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (6fce1f5) to head (3911745).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   94.92%   94.94%   +0.01%     
==========================================
  Files         237      238       +1     
  Lines       10058    10091      +33     
  Branches     1422     1429       +7     
==========================================
+ Hits         9548     9581      +33     
  Misses        392      392              
  Partials      118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but you need to improve coverage with tests, see Codacy report

@RicardoRibeiroRodrigues
Copy link
Contributor Author

Thank you for your review! I believe my latest commits should address the test coverage issue.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit cb45f4a into TheAlgorithms:master Aug 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants