Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Bellman ford algorithm and its test cases. #416

Merged
merged 11 commits into from
Oct 14, 2023

Conversation

Kpraful
Copy link
Contributor

@Kpraful Kpraful commented Oct 11, 2023

This PR adds BellmanFord algorithm and its test cases following the guideline and references from previous code.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@Kpraful Kpraful requested a review from siriak as a code owner October 11, 2023 00:48
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you decompose the algorithm into smaller functions so that it's easier to read and maintain?

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fe4b357) 96.04% compared to head (3ad6dde) 96.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
- Coverage   96.04%   96.03%   -0.02%     
==========================================
  Files         230      231       +1     
  Lines        9592     9665      +73     
==========================================
+ Hits         9213     9282      +69     
- Misses        379      383       +4     
Files Coverage Δ
Algorithms/Graph/BellmanFord.cs 94.52% <94.52%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kpraful
Copy link
Contributor Author

Kpraful commented Oct 11, 2023

Could you decompose the algorithm into smaller functions so that it's easier to read and maintain?

Hi, I have made changes in code, Please have a look, And thank you for swift resolution of issues.

@Kpraful Kpraful requested a review from siriak October 11, 2023 20:10
@Kpraful
Copy link
Contributor Author

Kpraful commented Oct 12, 2023

Hi, Can you please review PR.

Copy link
Contributor Author

@Kpraful Kpraful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the requested review and break it into smaller functions

Copy link
Contributor Author

@Kpraful Kpraful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes

Algorithms/Graph/BellmanFord.cs Show resolved Hide resolved
Algorithms/Graph/BellmanFord.cs Show resolved Hide resolved
Algorithms/Graph/BellmanFord.cs Show resolved Hide resolved
@Kpraful Kpraful requested a review from siriak October 13, 2023 18:53
Copy link
Contributor Author

@Kpraful Kpraful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes as adviced.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 102f8c6 into TheAlgorithms:master Oct 14, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants