Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AStar refactoring #396

Closed
wants to merge 2 commits into from
Closed

AStar refactoring #396

wants to merge 2 commits into from

Conversation

R0bari
Copy link

@R0bari R0bari commented Jun 23, 2023

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • [x ] Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@R0bari R0bari marked this pull request as ready for review June 23, 2023 07:04
@R0bari R0bari requested a review from siriak as a code owner June 23, 2023 07:04
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.23 🎉

Comparison is base (61d7716) 95.79% compared to head (c98b1c8) 96.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   95.79%   96.02%   +0.23%     
==========================================
  Files         220      220              
  Lines        8957     8935      -22     
==========================================
  Hits         8580     8580              
+ Misses        377      355      -22     
Impacted Files Coverage Δ
Algorithms/Search/AStar/AStar.cs 0.00% <0.00%> (ø)
Algorithms/Search/AStar/VecN.cs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@siriak siriak closed this Jun 23, 2023
@siriak siriak reopened this Jun 23, 2023
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there are no tests covering A*, could you add some that'd cover your changes?

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 24, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants