-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AStar refactoring #396
AStar refactoring #396
Conversation
R0bari
commented
Jun 23, 2023
- I have performed a self-review of my code
- My code follows the style guidelines of this project
- I have added tests that prove my fix is effective or that my feature works
- [x ] New and existing unit tests pass locally with my changes
- [x ] Comments in areas I changed are up to date
- I have added comments to hard-to-understand areas of my code
- I have made corresponding changes to the README.md
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 95.79% 96.02% +0.23%
==========================================
Files 220 220
Lines 8957 8935 -22
==========================================
Hits 8580 8580
+ Misses 377 355 -22
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there are no tests covering A*, could you add some that'd cover your changes?
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |