IWYU: fix missing headers for gui::-classes#9442
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Feb 8, 2026
Merged
IWYU: fix missing headers for gui::-classes#9442maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
gui::-classes#9442maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Breakdown: ``` src/drt/src/GraphicsFactory.cpp: #include "gui/gui.h" for gui::Gui src/grt/src/heatMap.cpp: #include "gui/heatMap.h" for gui::GlobalRoutingDataSource src/grt/src/heatMapRudy.cpp: #include "gui/heatMap.h" for gui::GlobalRoutingDataSource src/gui/src/browserWidget.cpp: #include "gui/gui.h" for gui::Gui src/gui/src/browserWidget.cpp: #include "layoutViewer.h" for gui::LayoutViewer src/gui/src/drcWidget.cpp: #include "inspector.h" for gui::ObjectTree src/gui/src/gotoDialog.cpp: #include "layoutTabs.h" for gui::LayoutTabs src/gui/src/heatMapPinDensity.cpp: #include "gui/heatMap.h" for gui::HeatMapDataSource src/gui/src/heatMapPlacementDensity.cpp: #include "gui/heatMap.h" for gui::HeatMapDataSource src/gui/src/heatMapSetup.cpp: #include "gui/heatMap.h" for gui::HeatMapDataSource src/gui/src/layoutTabs.cpp: #include "gui/gui.h" for gui::Gui src/gui/src/mainWindow.cpp: #include "findDialog.h" for gui::FindObjectDialog src/gui/src/mainWindow.cpp: #include "label.h" for gui::LabelDescriptor src/gui/src/mainWindow.cpp: #include "ruler.h" for gui::RulerDescriptor src/gui/src/renderThread.cpp: #include "label.h" for gui::Label src/gui/src/tclCmdInputWidget.cpp: #include "cmdInputWidget.h" for gui::CmdInputWidget src/gui/src/tclCmdInputWidget.cpp: #include "tclCmdHighlighter.h" for gui::TclCmdHighlighter src/gui/src/timingWidget.h: #include "gui/gui.h" for gui::Selected src/pdn/src/PdnGen.cc: #include "gui/gui.h" for gui::Gui src/psm/src/heatMap.cpp: #include "gui/heatMap.h" for gui::HeatMapDataSource ``` Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses missing header inclusions for various gui:: classes, as identified by IWYU (Include What You Use). The changes are straightforward, adding the necessary #include directives across multiple files to ensure proper compilation and dependency management. The changes are correct and improve the codebase's hygiene. The comment regarding include order for better code consistency has been retained.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breakdown: