Skip to content

Refresh absl-cpp and tcmalloc#9419

Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20260204-refresh-absl
Feb 7, 2026
Merged

Refresh absl-cpp and tcmalloc#9419
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20260204-refresh-absl

Conversation

@hzeller
Copy link
Contributor

@hzeller hzeller commented Feb 4, 2026

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the versions of absl-cpp and tcmalloc dependencies. The changes in MODULE.bazel look correct. However, there is a critical issue in etc/DependencyInstaller.sh where the checksum for Abseil was not updated along with its version, which will cause the installation script to fail.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

clang-tidy review says "All clean, LGTM! 👍"

@hzeller hzeller force-pushed the feature-20260204-refresh-absl branch from 6f5aa4f to 8bcb48c Compare February 4, 2026 14:29
@gadfort
Copy link
Collaborator

gadfort commented Feb 4, 2026

@maliberty due to the recent issues with this script, can we make sure this works correctly before merging?

@hzeller
Copy link
Contributor Author

hzeller commented Feb 4, 2026

Probably a good idea as I am doing the changes in the dependency script blind. I only use the bazel build.

@hzeller
Copy link
Contributor Author

hzeller commented Feb 5, 2026

the CI failures look unrealated.
I can't test the dependency script on my machine (I am using nix), so I'd say yolo it, then we can fix it later if there is an issue.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller force-pushed the feature-20260204-refresh-absl branch from 8bcb48c to 3d6152a Compare February 6, 2026 23:14
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

@gadfort I tested with your script from the previous issue and it built ok.

The pr-merge failure is the known flaky pdn test and is unrelated

@maliberty maliberty merged commit afd49e5 into The-OpenROAD-Project:master Feb 7, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants