Refresh absl-cpp and tcmalloc#9419
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions of absl-cpp and tcmalloc dependencies. The changes in MODULE.bazel look correct. However, there is a critical issue in etc/DependencyInstaller.sh where the checksum for Abseil was not updated along with its version, which will cause the installation script to fail.
|
clang-tidy review says "All clean, LGTM! 👍" |
6f5aa4f to
8bcb48c
Compare
|
@maliberty due to the recent issues with this script, can we make sure this works correctly before merging? |
|
Probably a good idea as I am doing the changes in the dependency script blind. I only use the |
|
the CI failures look unrealated. |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
8bcb48c to
3d6152a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@gadfort I tested with your script from the previous issue and it built ok. The pr-merge failure is the known flaky pdn test and is unrelated |
No description provided.