Repository navigation
Conversation
The cloud-component README documents executionReporter.error(msg) and the cloud worker provides it, but the local engine script did not, so calling it threw under thatopen run and local-server. Send it as an ERROR message, print it as [error], and record level "error" in local-server messages as the platform does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70.
src/cli/lib/engine-script.ts: the localexecutionReportergainserror(message), sent as anERRORmessage, so it matches the cloud-component README and the cloud worker.thatopen runprints it as[error]and keeps running (it is a log line, not a failure;FAILstill ends the run).local-serverrecords it like a message, withlevel: "error", as the platform's execution messages do.docs/cli/run.mdlists the new output type; patch changeset.Tests: new
src/cli/lib/engine-script.test.tsforks a generated engine script whosemain()callsexecutionReporter.errorand checks the IPC messages (ERROR, thenSUCCESS); it fails on main with theTypeError.yarn lint,tsc --noEmitandvitest runpass (152 tests).This touches the same
switchinrun.tsandexecution-manager.tsas #61, so whichever lands second needs a trivial rebase.