Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checking Windows console features #3598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lewis-yeung
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

On Windows, there is a use case where the standard output is redirected to a non-console object (e.g., a file), while the standard error is still connected to a console. So, similar to the fix in #3413, we should check console handles of both.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (02f3d14) to head (25b84f1).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3598   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          74       74           
  Lines        8095     8096    +1     
=======================================
+ Hits         7954     7955    +1     
  Misses        141      141           
Flag Coverage Δ
unittests 98.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants