Changing the category of two tests in from ID to NOD and marking one test as 'Opened' #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnanand5
changed the title
|
Why remove dianping/cat#2320 when it exists (and current remains open)? |
|
Apologies for leaving this open, Professor. The changes mentioned in this PR have been handled individually in 2 separate ones. Can I close this given its purpose is obsolete? |
|
Fine to close this PR if it got subsumed by others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update two different sections of pr-data.csv:
Based on the discussion in the email thread maintained with Professor Darko and concerned researchers, it was identified that the following tests were actually NOD and not ID:
com.dianping.cat.message.context.MessageIdFactoryTest.testDefaultDomainInParallel.com.dianping.cat.message.context.MessageIdFactoryTest.testGivenDomainInParallel.This PR intends to change their category from ID to NOD.
I have opened a real-world PR for
org.apache.druid.storage.s3.S3DataSegmentPusherConfigTest.testSerializationand the link for the same is apache/druid#15207