first try to test #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirtymew
suggested changes
Feb 6, 2025
dirtymew
left a comment
dirtymew
left a comment
There was a problem hiding this comment.
Привет Вячеслав
Хорошая работа - но есть замечания которые нужно поправить.
| func (t Training) meanSpeed() float64 { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return t.distance() / t.Duration.Hours() |
There was a problem hiding this comment.
тут возможно деление на 0 - стоило избежать
main.go
Outdated
| func (r Running) TrainingInfo() InfoMessage { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return InfoMessage{ |
main.go
Outdated
| func (w Walking) Calories() float64 { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return ((CaloriesWeightMultiplier*w.Weight + (math.Pow(w.meanSpeed(), 2)/w.Height)*CaloriesSpeedHeightMultiplier*w.Weight) * w.Duration.Hours() * MinInHours) |
main.go
Outdated
| func (w Walking) TrainingInfo() InfoMessage { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return InfoMessage{ |
| func (s Swimming) TrainingInfo() InfoMessage { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return InfoMessage{ |
| func (s Swimming) meanSpeed() float64 { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return float64(s.LengthPool) * float64(s.CountPool) / MInKm / s.Duration.Hours() |
Owner
Author
|
Антон, привет. Спасибо Вам за ваш чуткий взгляд, и что помогаете найти дьявола в деталях. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.