Skip to content

chore(deps-dev): bump @types/node from 22.19.17 to 24.13.3 - #296

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/types/node-24.13.3
Closed

chore(deps-dev): bump @types/node from 22.19.17 to 24.13.3#296
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/types/node-24.13.3

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor

Bumps @types/node from 22.19.17 to 24.13.3.

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
@types/node [>= 26.a, < 27]
@types/node [>= 25.a, < 26]

@dependabot @github

dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.17 to 24.13.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 24.13.3
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/types/node-24.13.3 branch from e8b3169 to 9322008 Compare August 6, 2026 01:36
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Test Coverage Report

Metric Coverage
Lines 88%
Statements 88%
Functions 84%
Branches 86.15%

@zeshi-du

Copy link
Copy Markdown
Contributor

Leaving this open. The bump itself is green and type-only, but it needs to land on our internal source-of-truth repo first — this repository is a per-release mirror, so a dependency change applied only here either blocks the next release snapshot or gets regenerated away by it.

One thing worth doing deliberately rather than automatically when we take it: @types/node 24 types against a Node 24 runtime, while package.json engines still admit ^20.19.0 || ^22.13.0. Bumping the types ahead of the minimum supported runtime can surface APIs that don't exist on Node 20, and the type checker won't complain. So this goes in alongside a look at the engines range, not before it.

Queued internally.

@zeshi-du

Copy link
Copy Markdown
Contributor

Holding this one deliberately — not because anything here is wrong, but because it would put our type layer a runtime ahead of anything we actually test.

package.json declares "node": "^20.19.0 || ^22.13.0 || >=24", but .github/workflows/ci.yml runs matrix.node-version: [20, 22] for both Unit Tests and Build. We claim to support Node 24 and never execute a single line on it. Moving @types/node to 24 means TypeScript starts accepting Node 24-only APIs while our declared floor is still 20.19 and nothing in CI would notice — the failure would surface as a runtime crash on a supported version, not as a red check.

That is a gap worth closing in the other order: add Node 24 to the Unit Tests and Build matrices first, then take this bump. I'll open that separately.

Nothing to do on your side, dependabot — this will be picked up again once the matrix covers 24.

@zeshi-du

Copy link
Copy Markdown
Contributor

Closing this, but not because of the major version. package.json already declares "engines": { "node": "^20.19.0 || ^22.13.0 || >=24" } — Node 24 is a supported runtime here today, so this bump isn't asking us to accept something we've declined; it's just a routing decision.

One correction to make explicit rather than let stand: the passing run on 93220089 (2026-08-06) is not evidence this is green against our current gates. That run predates the security workflow entering this repo — it has no Dependency Review, ESLint Security, Dependency Audit, or CodeQL job at all, only the older Build/Typecheck/Lint/Test/Coverage set. So the honest statement is "passed the matrix that existed on Aug 6," not "green" — it's never actually run against the checks that gate everything else in this repo now.

This repo is a mirror: dependency bumps are made in our source repo and arrive here via release snapshot, so it's closed here regardless.

What would change the answer: when the equivalent @types/node bump lands via the next release snapshot, it'll run against the current gate matrix for the first time — worth a look then, but not a reason to keep this PR open now.

@zeshi-du zeshi-du closed this Aug 19, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/types/node-24.13.3 branch August 19, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant