Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video inseration support #44

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

Gronex
Copy link

@Gronex Gronex commented Jul 26, 2015

Support for inserting videos, with auto conversion of youtube and vimeo links to use their respective players.
Also a bit of IE 11 bugfixing

@TerryMooreII
Copy link
Owner

This is awesome. I will pull it down and test it over the next day or so. Two things: 1) This has a merge conflict. 2) Why did you change textareaId to textareaid? This is a breaking change for anyone that has already has this implemented.

@Gronex
Copy link
Author

Gronex commented Jul 29, 2015

The case change was a stupid mistake on my part.
And the merge conflicts was a result of me being new to pull requests, and not knowing i could merge the original repo down again.
I should now have resolved the two concerns you had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants