Skip to content

Fix VNC required argument handshake#968

Merged
LukeGus merged 1 commit into
Termix-SSH:dev-2.5.0from
ZacharyZcR:fix/support-906-vnc-required-handshake
Jun 28, 2026
Merged

Fix VNC required argument handshake#968
LukeGus merged 1 commit into
Termix-SSH:dev-2.5.0from
ZacharyZcR:fix/support-906-vnc-required-handshake

Conversation

@ZacharyZcR

Copy link
Copy Markdown
Member

Summary

  • handle guacd required/require argument requests in the guacamole-lite patch
  • send stored connection settings back through argv/blob/end streams instead of forwarding the request to the browser
  • add a regression test that verifies the patched guacamole-lite client handles dynamic argument requests

Verification

  • node scripts/patch-guacamole-lite.cjs
  • npm exec vitest run -- scripts/patch-guacamole-lite.test.ts
  • npx prettier --check .
  • npm run lint
  • npx tsc --noEmit
  • npm run build

Fixes Termix-SSH/Support#906

@LukeGus LukeGus merged commit 39df8ac into Termix-SSH:dev-2.5.0 Jun 28, 2026
1 check passed
@LukeGus

LukeGus commented Jun 28, 2026

Copy link
Copy Markdown
Member

LGTM, thanks

@ZacharyZcR ZacharyZcR deleted the fix/support-906-vnc-required-handshake branch June 28, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants