fix: use correct translation key for nav.close#964
Closed
reppiz wants to merge 4 commits into
Closed
Conversation
… system not loading
nav.closeTab doesn't exist in the en.json locale file. There is a nav.close so I imagine this what we want. Using nav.closeTab shows up as text when right clicking the existing connection tabs.
LukeGus
added a commit
that referenced
this pull request
Jun 28, 2026
Member
|
LGTM, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixed invalid translation key for close tab.
nav.closeTabdoesn't exist in the JSON locale files. There is anav.closeso I imagine this what we want.Using
nav.closeTabshows up as text when right clicking the existing connection tabs.Changes Made
/src/ui/shell/TabBar.tsxchanged line 565 from
{t("nav.closeTab")}to{t("nav.close")}.