Repository navigation
fix: resolve recent activity hosts by ID - #3
Merged
LukeGus merged 2 commits intoNov 7, 2026
Merged
Conversation
|
AI review | Looks safe to merge The change updates recent activity host resolution to use IDs instead of names, preventing incorrect host selection when names are reused or changed. It includes tests for the new behavior and maintains backward compatibility, with no security or stability risks. Reviewed 97bb865. AI can be wrong, a maintainer still decides. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent activity in the command palette resolves its historical host name against the current host list. Renaming a host, reusing its old name or having duplicate names can therefore open a different host. A deleted host can also redirect to a same-name replacement.
Resolve activity by host ID and pass the selected host through to tab opening. Missing hosts do not open a replacement, and singleton tab routing is preserved.
Related: Termix-SSH/Plugin-SSH-Terminal#53. This fixes a reproduced command-palette defect in Classic Layout; the dashboard card already resolves by ID, so it does not establish that every interaction described in that report is resolved.
Validation: regressions cover renamed, duplicate-name and deleted hosts. All 444 tests, typecheck, build, manifest validation and formatting passed.
The SDK lockfile is synchronized. A fresh
npm cifollowed by tests, typecheck, build, validation, pack and formatting passes.