New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(knapsack): docs for full screen dialog and focused page #2275

Open

bsahitya wants to merge 2 commits into main from docs/knapsack-fullscreen-dialog

Collaborator

bsahitya commented Nov 6, 2024 •

edited

Loading

Description

Knapsack documentation for full screen dialog and focused page.
Fix for styling issue in full screen dialog which causes the dialog to flash.

What's included?

Fix flashing issue in full screen dialog component
Knapsack docs for full screen dialog and focused page

Test Steps

nx run knapsack:serve
Navigate to Components -> Full-screen dialog or Focused page
Verify the docs

General Tests for Every PR

npm run start still works.
npm run lint passes.
npm run stylelint passes.
npm test passes and code coverage is not lower.
npm run build still works.

Screenshots or link to StackBlitz/Plunker

Full-screen dialog close transition

bsahitya added 2 commits

November 6, 2024 16:20


          docs(knapsack): docs for full screen dialog and focused page

22ae283


          fix(chromatic): revert knapsack update

2751d70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet