Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): relative href links in md and minor styling #2194

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

JulieMarie
Copy link
Collaborator

Description

Fixes small bugs in 4.17.0 release

What's included?

  • Fixed another issue with markdown where links in a markdown file that link to other markdown files were not working when offline
  • Fixed undesired uppercase of buttons for dialogs
  • Fixed handle for markdown navigator window that wasn't displaying properly

Test Steps

  • npm run start
  • then this
  • finally this

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

@owilliams320 owilliams320 merged commit 44aea1e into release/4.x.x Jul 19, 2024
4 checks passed
@owilliams320 owilliams320 deleted the fix/markdown-using-relative-paths-pt2 branch July 19, 2024 16:42
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 4.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown component doesn't handle links to other markdown files when offline
2 participants