Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: updated knapsack docs for web components #2127

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

bsahitya
Copy link
Collaborator

Description

Updated the knapsack docs for web components.
Fixed the style issues for badge component.

What's included?

  1. Components updated are:
  • Chip
  • Circular progress
  • Dialog
  • Empty state
  • Expansion panel
  • Form field
  • Icon
  • Icon button
  1. Fix for the style issues in badge component

Test Steps

  • Run start for knapsack using nx console
  • Open the localhost url
  • Test the changes

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots

knapsack-docs

@owilliams320 owilliams320 merged commit c63e5b4 into main Mar 21, 2024
7 checks passed
@owilliams320 owilliams320 deleted the docs/knapsack-components-group2 branch March 21, 2024 14:56
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants