Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): create a badge web component #2121

Merged
merged 2 commits into from
Mar 18, 2024
Merged

feat(components): create a badge web component #2121

merged 2 commits into from
Mar 18, 2024

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Mar 14, 2024 •
edited
Loading

Description

Created a badge (cv-badge) web component.

What's included?

  • Badge component with the below properties:
    • content
    • size
    • max
    • verticalAlignment
    • horizontalAlignment
    • showZero
    • hideBadge

Test Steps

  • npm run storybook
  • Navigate to Components/Badge
  • Test with all properties

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots

Badge-component

@bsahitya bsahitya force-pushed the feat/badge-component branch 2 times, most recently from 3e4eb8d to 403b274 Compare March 15, 2024 14:22
owilliams320
owilliams320 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@owilliams320 owilliams320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@owilliams320 owilliams320 merged commit 148c9c3 into main Mar 18, 2024
7 checks passed
@owilliams320 owilliams320 deleted the feat/badge-component branch March 18, 2024 14:04
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owilliams320 owilliams320 owilliams320 approved these changes

Assignees
No one assigned
Labels
feature released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsahitya @owilliams320