Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): add tooltips to show cut-off text in User Profile Component #2007

Closed
wants to merge 1 commit into from

Conversation

wahmd
Copy link

@wahmd wahmd commented Feb 2, 2023

Description

  • added tooltips to show complete text when hovering on email & names to fix text cut-off issue.
  • imported & declared matToolTipModule to use inside user-profile component

What's included?

  • Show the complete email using tooltip on hovering the displayed email in user-profile component.
  • Show the complete name using tooltip on hovering the displayed namein user-profile component.

Test Steps

  • npm run start
  • Add a really long email or name to the user profile component demo
  • Click on 'Open profile'
  • Hover over the cut off email or name
  • You can view the tooltip

Screenshot:
ss

@wahmd wahmd mentioned this pull request Feb 2, 2023
@owilliams320
Copy link
Collaborator

@wahmd can you include a screenshot? thanks!

@wahmd
Copy link
Author

wahmd commented Feb 22, 2023

@owilliams320 updated the description with SS. Please review.

@owilliams320
Copy link
Collaborator

closes #1954

@wahmd
Copy link
Author

wahmd commented May 7, 2023

@owilliams320 curious to know why this PR is not merged yet.

@owilliams320
Copy link
Collaborator

Hello @wahmd. Apologies for the delay. Spoke with our UX team. The desire is to have whole panel expand the width of the contents instead of showing a tooltip and cutting off with the ... If you would like to contribute we have a very similiar Issue flagged by our UX team for fit and finish of this user profile component. #1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants