SVG export module, converting drawing commands to SVG text #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YGaurora
requested review from
kevingpqi123,
domchen,
Hparty,
lvpengwei and
shlzxjp
as code owners
domchen
reviewed
Dec 9, 2024
domchen
reviewed
Dec 9, 2024
domchen
reviewed
Dec 9, 2024
domchen
reviewed
Dec 9, 2024
domchen
reviewed
Dec 9, 2024
domchen
reviewed
Dec 9, 2024
domchen
reviewed
Dec 9, 2024
domchen
reviewed
Dec 9, 2024
domchen
reviewed
Dec 12, 2024
shlzxjp
reviewed
Dec 12, 2024
| * unicode. The array length is glyphsCount(). | ||
| * The length of the array is not required, it will be resized within the method. | ||
| */ | ||
| virtual std::vector<Unichar> getGlyphToUnicodeMap() const = 0; |
There was a problem hiding this comment.
这里的vector表示了两层含义，替代了map的作用，理解上不是太直观
There was a problem hiding this comment.
它这里要兼顾性能，GlyphID是连续线性，直接构造vector的查性能最高，用map会很慢。Skia也是这么处理。
|
|
||
| class ShaderCaster { | ||
| public: | ||
| static std::shared_ptr<const ColorShader> AsColorShader(const std::shared_ptr<Shader>& shader); |
There was a problem hiding this comment.
这个方法有地方使用吗？没搜索到调用的地方，下面的几个方法都看看是在哪些地方使用的。
There was a problem hiding this comment.
都是在ElementWriter中使用
Comment on lines
+143
to
+145
| Rect srcRect = Rect::MakeWH(image->width(), image->height()); | ||
| float scaleX = rect.width() / srcRect.width(); | ||
| float scaleY = rect.height() / srcRect.height(); |
There was a problem hiding this comment.
rect在exportGlyphsAsImage方法中，是通过image来构造的，这里rect.width() / srcRect.width()不是一直等于1吗？
There was a problem hiding this comment.
其实drawImageRect也是drawContext的虚函数，一些带矩阵渲染图片的接口，都会进入到这个函数实现
domchen
reviewed
Dec 12, 2024
domchen
reviewed
Dec 12, 2024
domchen
reviewed
Dec 12, 2024
domchen
reviewed
Dec 12, 2024
domchen
reviewed
Dec 12, 2024
domchen
reviewed
Dec 12, 2024
domchen
reviewed
Dec 12, 2024
domchen
reviewed
Dec 12, 2024
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
| * SVG will be clipped. | ||
| * @param options Options for exporting SVG text. | ||
| */ | ||
| static std::shared_ptr<SVGExporter> Make(std::stringstream& svgStream, Context* context, |
There was a problem hiding this comment.
这里不能直接用std::stringsteam, 这个会一直在内存里，我们之所以要支持stream就是为了可以减少内存占用，背后可以包装一个FILE对象，直接写入磁盘。这里应该像Skia一样定义一个WStream基类，但是提供一些基本的实现，有FileWStream，也可以创建MemoryWStream，内部实现再包装std::stringstream
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
domchen
reviewed
Dec 18, 2024
shlzxjp
reviewed
Dec 18, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG导出部分的实现，将canvas的绘制指令转成SVG文本