Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): onInputChange miss callback second parameters #4850

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Dec 18, 2024

fix(select): onInputChange triggered when the panel is expanded
test(select): add test for onInputChange

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(select): onInputChange 事件丢失第二个参数

  • fix(select): onInputChange 事件在面板展开时被触发

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Dec 18, 2024

完成

@RSS1102
Copy link
Contributor Author

RSS1102 commented Dec 21, 2024

目前看起来这个pr 没有问题。

和 vue2、react 表现不一样。
目前看起来 vue3 通过每次选中之后清空 filter 的值避免在 react 中出现的 在 filter 之后仍可以使用 全选功能,从而导致 filter 下的全选只选择了 filter 之后的那部分数据,造成了“假全选”。

Recording.2024-12-22.031747.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant