Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ConfigProvider): support global Jumper slot for Pagination #3421

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

RylanBot
Copy link
Collaborator

@RylanBot RylanBot commented Mar 7, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(ConfigProvider): support global Jumper slot for Pagination

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Mar 7, 2025

完成

@RylanBot RylanBot force-pushed the feat/pagination/jumper branch from ff7a7bd to e9722ac Compare March 7, 2025 13:33
@HaixingOoO HaixingOoO requested a review from Copilot March 8, 2025 05:12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR introduces a global jumper slot for Pagination through updates in the configuration provider and Pagination component, while also revising related configuration documentation.

  • Added a GlobalJumper component example in the ConfigProvider demo for Pagination.
  • Updated the Pagination component to conditionally render a global jumper provided via configuration.
  • Revised configuration documentation to reflect new API changes.

Reviewed Changes

File Description
packages/components/config-provider/_example/pagination.tsx Added GlobalJumper example demonstrating usage of a global jumper slot in Pagination.
packages/components/pagination/Pagination.tsx Updated logic to retrieve and use a global jumper component via configuration.
packages/components/config-provider/config-provider.en-US.md
packages/components/config-provider/config-provider.md
Adjusted configuration documentation to introduce new PaginationConfig entries and update language text.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

packages/components/config-provider/_example/pagination.tsx:20

  • The inline style for width is specified as a number without a CSS unit; consider using a unit (e.g., '10px') to ensure consistent rendering.
          style={{ width: 10 }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant