fix(drawer): 解决Drawer抽屉在拖拽改变大小的时候获取宽度可能不正确的问题 #3420
+49
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
解决Drawer抽屉在拖拽改变大小的时候获取宽度可能不正确的问题
wonkzhang
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
wonkzhang
commented
Mar 7, 2025
| @@ -9,36 +9,43 @@ const useDrag = ( | |||
| onSizeDragEnd: TdDrawerProps['onSizeDragEnd'], | |||
| ) => { | |||
| const [dragSizeValue, changeDragSizeValue] = useState<string>(null); | |||
| // 使用 ref 来存储当前拖拽的宽度值 | |||
| const dragSizeNumberRef = useRef<number>(0); | |||
wonkzhang
commented
Mar 7, 2025
|
|
||
| if (typeof moveSize === 'undefined') return; | ||
| changeDragSizeValue(`${moveSize}px`); | ||
| dragSizeNumberRef.current = moveSize; |
wonkzhang
commented
Mar 7, 2025
| onSizeDragEnd?.({ | ||
| e, | ||
| // 此处不要使用 dragSizeValue，useState 的更新是异步的，在鼠标拖拽的同步操作中取不到最新的值 | ||
| size: dragSizeNumberRef.current, |
|
|
There was a problem hiding this comment.
PR Overview
This PR fixes an issue where the Drawer component was not obtaining the correct width during drag-resize operations by switching from state to a ref for tracking the latest drag size.
- Changed handleMousemove and handleMouseup to use useCallback for improved performance and stability.
- Introduced a ref (dragSizeNumberRef) to store the current drag size, ensuring the handleMouseup callback accesses the latest value.
Reviewed Changes
| File | Description |
|---|---|
| packages/components/drawer/hooks/useDrag.ts | Updated drag handling logic to use useCallback and a ref for the drag size to fix stale state issues |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/components/drawer/hooks/useDrag.ts:13
- [nitpick] The variable name 'dragSizeNumberRef' is a bit verbose. Consider renaming it to 'dragSizeRef' for improved readability.
const dragSizeNumberRef = useRef<number>(0);
const dragSizeRef = useRef<number>(0); 感觉变量名可以这个 |
uyarn
reviewed
Mar 8, 2025
… 后续不必要的计算 调整了变量dragSizeRef的命名;将allowSizeDraggable的判断逻辑提升到了函数的顶部,避免 后续不必要的计算
|
HaixingOoO
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决Drawer抽屉在拖拽改变大小的时候获取宽度可能不正确的问题
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
在
useDrag.ts文件中， handleMouseup 函数中的 dragSizeValue 每次取值不正确的问题，是由于 dragSizeValue 的状态更新不及时导致的。 useState 的更新是异步的，因此在 handleMouseup 中直接使用 dragSizeValue 会导致获取到的值不是最新的。解决方案是使用 useRef 来存储最新的 dragSizeValue ，这样可以确保在 handleMouseup 中获取到的值是最新的。
📝 更新日志
fix(Drawer): 解决Drawer抽屉在拖拽改变大小的时候获取宽度可能不正确的问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单