Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): disable password toggle when input disabled #2991

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix(input): disable password toggle when input disabled #2991

merged 1 commit into from
Jul 12, 2024
+13 −1

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jul 12, 2024 •
edited

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Input): 修复禁用状态下仍可以切换明文密文的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

NWYLZW
NWYLZW reviewed Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@NWYLZW NWYLZW left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉 break 了，不过加着吧，看了一下隔壁的组件库确实都是这么做，不过有一个 togglevisible 的参数用来控制是否展示

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited

完成

@uyarn
Copy link
Collaborator Author

uyarn commented Jul 12, 2024

感觉 break 了，不过加着吧，看了一下隔壁的组件库确实都是这么做，不过有一个 togglevisible 的参数用来控制是否展示

会有disabled下还允许查看的情况？

@uyarn uyarn merged commit fdad042 into develop Jul 12, 2024
8 checks passed
@uyarn uyarn deleted the fix/input-password branch July 12, 2024 13:17
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NWYLZW NWYLZW NWYLZW left review comments

@HaixingOoO HaixingOoO HaixingOoO approved these changes

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uyarn @NWYLZW @HaixingOoO