Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle interactive pop gesture when calling the popViewControllerAnimated: method #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MoZhouqi
Copy link

No description provided.

@Zepo
Copy link
Collaborator

Zepo commented Feb 25, 2016

TransitionCoordinator is not working in situation where popping an UIViewController WITHOUT animation.

@MoZhouqi
Copy link
Author

Thanks, it has been fixed.

@Zepo
Copy link
Collaborator

Zepo commented Feb 25, 2016

这个方法挺不错的,先赞一个。还有两点:

  1. !context.percentComplete 这个条件应该是没必要的,percentComplete 是手指松开那一刻的动画的百分比,基本不可能为 0。
  2. 目前 MLeaksFinder 的 target 是 iOS 6,而 TransitionCoordinator 需要 iOS 7 以上。不过 iOS 6 也差不多可以抛弃了。可以把 MLeaksFinder 的 target 改 iOS 7。

@MoZhouqi
Copy link
Author

  1. 恩,你说得对,!context.percentComplete 是为了区分从手势返回还是按返回按钮返回,当时没多想就写上去了,现在的这个场景没有必要,代码已做修改;
  2. 等最低支持版本改成 iOS 7 后,可以把这个 pr 合进去。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants