Added a event for opening #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am working on a huge addition at the moment and a feature related to this will be on it. |
SuricateCan
pushed a commit
to SuricateCan/ui.bootstrap.contextMenu
that referenced
this pull request
Oct 13, 2015
Several additions: * Issues: - Templarian#22 Adding a context menu class name to dropdown: Class ng-bootstrap-contextmenu is now appended to the holding div; * Pull Requests - Templarian#17 Added a event for opening: Added event for opening, after open and after closed; - Templarian#21 Allow icons (as HTML) in menu item: Not as html, but the new builder api handles the icon submission; - Templarian#25 Added support for item text promise: The text is now wrapped inside a $q.when function.
|
@Templarian what do you think of this? @zestime can you also add a change to README to inform of the changes in this PR? |
|
I like this idea a lot, it matches the ability that other Angular UI components have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contextMenu.
It's really helpful to my work.
I needed a feature about opening. When users try to open contextMenu, I have to figure out whether opening or not. So, I added a handler for 'context-menu-opening'. I modified your example a little bit. link to codepen!
And your code is good for understanding directives in AngularJS. :)