Async Task Interface for long running functions#410
Open
Tinyblargon wants to merge 7 commits intoTelmate:masterfrom
Open
Async Task Interface for long running functions#410Tinyblargon wants to merge 7 commits intoTelmate:masterfrom
Tinyblargon wants to merge 7 commits intoTelmate:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
proxmox/vmref.go:18
- Consider using fmt.Errorf to wrap errors for a more consistent error formatting style when passing context with the error message.
return nil, nil, errors.New(VmRef_Error_Nil)
proxmox/config_qemu_disk.go:913
- Explicitly return nil for the exitStatus when an error occurs (e.g., 'return nil, err') to avoid relying on implicit zero values from named return parameters.
if err != nil { return }
proxmox/client.go:41
- [nitpick] Ensure that the Features field is actively utilized to conditionally handle async task flows or consider adding clarifying comments since its purpose is not immediately evident in the current implementation.
Features *FeatureFlags
Collaborator
Author
|
@fireflg would this new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Taskinterface that can be used for asynchronously awaiting the completion of the task.The async part is enabled with the
Features.AsyncTaskflag in theClientstruct.Resolves #388
Supersedes:
Closes #397
Closes #389