Skip to content

Avoid blocking main thread for backupCache calls when leaving app #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Avoid blocking main thread for backupCache calls when leaving app #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
622fcbf
Avoid blocking main thread for backupCache calls when leaving app
Jeehut Sep 21, 2024
275901d
Add back build support for macOS & watchOS
Jeehut Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions Sources/TelemetryDeck/Signals/SignalManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,23 @@ final class SignalManager: SignalManageable, @unchecked Sendable {
// MARK: - Notifications

private extension SignalManager {
@MainActor
@objc func appWillTerminate() {
configuration.logHandler?.log(.debug, message: #function)
signalCache.backupCache()

#if os(watchOS) || os(macOS)
self.signalCache.backupCache()
#else
// run backup in background task to avoid blocking main thread while ensuring app stays open during write
let backgroundTaskID = UIApplication.shared.beginBackgroundTask()
DispatchQueue.global(qos: .background).async {
self.signalCache.backupCache()

DispatchQueue.main.async {
UIApplication.shared.endBackgroundTask(backgroundTaskID)
}
}
#endif
}

/// WatchOS doesn't have a notification before it's killed, so we have to use background/foreground
Expand All @@ -168,13 +182,26 @@ private extension SignalManager {
sendCachedSignalsRepeatedly()
}

@MainActor
@objc func didEnterBackground() {
configuration.logHandler?.log(.debug, message: #function)

sendTimer?.invalidate()
sendTimer = nil

signalCache.backupCache()
#if os(watchOS) || os(macOS)
self.signalCache.backupCache()
#else
// run backup in background task to avoid blocking main thread while ensuring app stays open during write
let backgroundTaskID = UIApplication.shared.beginBackgroundTask()
DispatchQueue.global(qos: .background).async {
self.signalCache.backupCache()

DispatchQueue.main.async {
UIApplication.shared.endBackgroundTask(backgroundTaskID)
}
}
#endif
}
#endif
}
Expand Down