Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News Site #505

Closed
wants to merge 4 commits into from
Closed

News Site #505

wants to merge 4 commits into from

Conversation

jingh999
Copy link

@jingh999 jingh999 commented Feb 5, 2024 •
edited
Loading

@AntonellaMorittu
Copy link

Hi Jing, please provide a link to your deployed version. Thank you :)

AntonellaMorittu
AntonellaMorittu approved these changes Feb 7, 2024
View reviewed changes
Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Jing, congratulations for completing your first project! You've done a really good job using flexboxes and grids, your app is fully responsive and you have a very good sense of aesthetic, the UI is on point! You worked well also in the code, being organised and having it formatted. Just a tiny improvement would be to keep all images in the assets folder, other than that, well done! 👏

@jingh999
Copy link
Author

jingh999 commented Feb 7, 2024 via email

@HIPPIEKICK HIPPIEKICK closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonellaMorittu AntonellaMorittu AntonellaMorittu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingh999 @AntonellaMorittu @HIPPIEKICK