Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News-site-libn #502

Closed
wants to merge 7 commits into from
Closed

News-site-libn #502

wants to merge 7 commits into from

Conversation

linaroos
Copy link

@linaroos linaroos commented Feb 5, 2024

My first project

Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lina, good job completing your first assignment! Cool choice of concept, I am also watching Love is Blind haha :)
Please make sure that you test your app to be responsive, here from the instructions:

  • Create a responsive design with the following views: Desktop 4 columns, tablet 2 columns, mobile 1 column (it should look good on devices from 320px width up to 1600px).

Update your repository to pass the assignment, thank you 💪

@linaroos
Copy link
Author

linaroos commented Feb 5, 2024

Hi Antonella, I made the changes, did I get it right?
Many thanks!

Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again 👋 the layout is still not responsive in the correct way. I suggest you check again this video where it's explained how to use grids to achieve the correct layout:

Desktop 4 columns, tablet 2 columns, mobile 1 column (it should look good on devices from 320px width up to 1600px)

Almost there 💪

@linaroos
Copy link
Author

linaroos commented Feb 7, 2024

Hi Antonella, I am really trying, but still not sure if this one is correct. Almost feels like I want to start over to make it right from the beginning. However, fingers crossed 😅

@AntonellaMorittu
Copy link

Screenshot 2024-02-08 at 13 47 18 Hi Lina, you only need to fix the desktop layout now, 4 columns per row! See screenshot :) If you have doubts or questions you can always ask support on the slack channel #code-help or Stack Overflow :)

@linaroos
Copy link
Author

linaroos commented Feb 9, 2024

Thank you Antonella for all patience, I finally got it 😄

Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lina, looks so much better now! yay 🥳

@HIPPIEKICK HIPPIEKICK closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants