-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News-site-libn #502
News-site-libn #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Lina, good job completing your first assignment! Cool choice of concept, I am also watching Love is Blind haha :)
Please make sure that you test your app to be responsive, here from the instructions:
- Create a responsive design with the following views: Desktop 4 columns, tablet 2 columns, mobile 1 column (it should look good on devices from 320px width up to 1600px).
Update your repository to pass the assignment, thank you 💪
Hi Antonella, I made the changes, did I get it right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again 👋 the layout is still not responsive in the correct way. I suggest you check again this video where it's explained how to use grids to achieve the correct layout:
Desktop 4 columns, tablet 2 columns, mobile 1 column (it should look good on devices from 320px width up to 1600px)
Almost there 💪
Hi Antonella, I am really trying, but still not sure if this one is correct. Almost feels like I want to start over to make it right from the beginning. However, fingers crossed 😅 |
Thank you Antonella for all patience, I finally got it 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Lina, looks so much better now! yay 🥳
My first project