Yifan Wang/News-site-for-pre-course #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonellaMorittu
suggested changes
Feb 5, 2024
|
Thank you! I just updated my repo. But I'm not sure how to mark the requested changes as "resolved". |
AntonellaMorittu
suggested changes
Feb 6, 2024
There was a problem hiding this comment.
Hi Yifan, there is still no 2 columns applied to all tablet sizes. Is the link to the deployed version the same? Please refactor your code and follow the examples you can find on Notion material. Thank you for reviewing your code :)
|
Hey Antonella, I've updated the media queries for tablets as "@media only screen and (min-width: 481px) and (max-width: 1024px)" in the CSS file and pushed it to my repo. However, it seems that Netlify hasn't updated the site. I will try to deploy it again to see if that can solve the problem! |
|
I just deployed the site again in Netlify. It seems to be working now. |
AntonellaMorittu
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.