Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy Thoughts - Martin #69

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Martin-Joensson
Copy link

Copy link
Contributor

@dzc1 dzc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grat project Martin 💪💪💪

Loving to see the simplicity yet effectiveness of your syntax and it seems that you are grasping the full power of the react ecosystem. Destructuring comps as well provides a smooth review. Keep up the amazing work Martin!

Copy link

@Caracal23 Caracal23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Martin, your code is well organized, easy to follow/read. Great use on the knowledge learn 🚀

--clr_form_background: #f2f0f0;
--clr_heart_button: #ffadad;
--clr_heart_button_hover: #efefef;
--clr_heart_button_active: grey;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job in creating and assingning CSS classes 👏🏻

import PropTypes from "prop-types";

export const Time = (props) => {
const now = new Date();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the logic for calculating the time stam; I used another approach with the Dependency of "moment". Maybe you find it useful next time 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants