Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NPE that occurs when both
save-empty-inventoriesandallow-other-plugins-edit-death-inventoryare set to false and a player dies with an empty inventoryTo avoid NPE in
ConcurrentHashMapwe can't simply add null check for snapshot. Doing so would causeplayerDeathHandleto skip pre-death validation when inventories are emptyThis change replaces null returns with a static empty snapshot, allow
deathPreSnapshotsto safely store the state while ensuring that empty inventories are correctly ignored across all saving logic without NPEEventLogs.java#L126
NPE stacktrace