-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge design to master #23
Open
danagilliann
wants to merge
21
commits into
v3
Choose a base branch
from
design
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanup for fonts and fonts files header has descriptive title and mobile friendly changed font size header links to homepage added post a job button button location makes sense, changed names of ctrls and started changes on job listing follows style guide contact changed post of job to h1 added tags changed hover of button changed tags again fixed sanitize issue in for a job slowly fixing calendar header respnsive for mobile improve responsiveness made buttons vmin
Couple notes:
Looks a helluva lot better! Good work |
Haven't looked at this in detail, but: every job should have either an application URL or an email to apply with. So, hopefully, if there's no url, it could show the email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
I was able to remove the ng-sanitize error on the front-end for the list of jobs page (aka index). This is still a problem for a single job (the problem is much more complicated here). However, the ng-sanitize problem is solved for the jobs page.
The images, buttons, and header used to cause problems. It is not as responsive as I would have hoped for < iPhone 5s, it is responsive for most devices. In the future, I would like to improve responsiveness further, but majority of the solution is solved.
Every job post in the list of jobs has an apply button. There are less steps for the user.
Enhances the site more.
I think I was able to squash the commits??