Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge design to master #23

Open
wants to merge 21 commits into
base: v3
Choose a base branch
from
Open

Merge design to master #23

wants to merge 21 commits into from

Conversation

danagilliann
Copy link
Contributor

Major changes:

  1. No more ng-sanitize error on jobs
    I was able to remove the ng-sanitize error on the front-end for the list of jobs page (aka index). This is still a problem for a single job (the problem is much more complicated here). However, the ng-sanitize problem is solved for the jobs page.
  2. Responsiveness.
    The images, buttons, and header used to cause problems. It is not as responsive as I would have hoped for < iPhone 5s, it is responsive for most devices. In the future, I would like to improve responsiveness further, but majority of the solution is solved.
  3. Apply buttons
    Every job post in the list of jobs has an apply button. There are less steps for the user.
  4. Colorful tags
    Enhances the site more.

I think I was able to squash the commits??

danagilliann and others added 21 commits March 15, 2016 01:38
cleanup for fonts and fonts files

header has descriptive title and mobile friendly

changed font size

header links to homepage

added post a job button

button location makes sense, changed names of ctrls and started changes on job listing

follows style guide

contact

changed post of job to h1

added tags

changed hover of button

changed tags again

fixed sanitize issue in for a job

slowly fixing calendar

header respnsive for mobile

improve responsiveness

made buttons vmin
@brentdur
Copy link
Contributor

Couple notes:

  • not every job has an ApplicationURL, in this case I think the apply button should redirect to the description page but I'll leave that up to you. It should just do something
  • the description pages aren't loading
  • for jobs that don't have categories it just says "| Full-time". For consistency's sake not sure if there should be a leading bar. Again, up to you

Looks a helluva lot better! Good work

@ethanresnick
Copy link
Member

Haven't looked at this in detail, but: every job should have either an application URL or an email to apply with. So, hopefully, if there's no url, it could show the email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants