Set destructiveHint and openWorldHint explicitly on every tool - #420
Merged
Conversation
OpenAI's app review rejected the submission because 190 tools omitted openWorldHint and/or destructiveHint from tools/list. Both are *bool with omitempty in go-sdk, so a nil value is dropped from the payload and the MCP spec then defaults each to true — the server was implicitly declaring every read tool open-world and destructive. (readOnlyHint was never actually missing: go-sdk v1.7 serializes it as a plain bool, false included.) All 221 tool definitions across twprojects, twdesk, twchat and twspaces now set both hints to a concrete value. Values follow the existing convention and are unchanged where already declared: false everywhere, except DestructiveHint on the delete tools plus Desk create_ticket and reply_ticket, and OpenWorldHint on helpdoc create/update and those same two ticket tools. TestAnnotationHintsAreExplicit in cmd/docs-gen builds all four products with allowDelete=true and fails on any nil hint, so a new tool cannot ship without them; it also rejects a tool annotated both read-only and destructive. Documented in the AGENTS.md tool checklist. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenAI's app review rejected the submission because 190 tools omitted
openWorldHintand/ordestructiveHintfrom tools/list. Both are *bool with omitempty in go-sdk, so a nil value is dropped from the payload and the MCP spec then defaults each to true — the server was implicitly declaring every read tool open-world and destructive. (readOnlyHint was never actually missing: go-sdk v1.7 serialises it as a plain bool, false included.)All 221 tool definitions across twprojects, twdesk, twchat and twspaces now set both hints to a concrete value. Values follow the existing convention and are unchanged where already declared: false everywhere, except DestructiveHint on the delete tools plus Desk create_ticket and reply_ticket, and OpenWorldHint on helpdoc create/update and those same two ticket tools.
TestAnnotationHintsAreExplicit in cmd/docs-gen builds all four products with allowDelete=true and fails on any nil hint, so a new tool cannot ship without them; it also rejects a tool annotated both read-only and destructive and documented in the
AGENTS.mdtool checklist.Type of Change
Testing
go test -v ./...)Checklist