Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mobs to transformation powder #2150

Open
wants to merge 8 commits into
base: 1.21.x
Choose a base branch
from

Conversation

Sleepy-Horse
Copy link

Add #2133:
Carminite Golem <---> Iron Golem
Stable Ice Core <---> Snow Golem
Squirrel <---> Fox
Hedge Spider <---> Spider
Carminite Broodling <---> Cave Spider

Copy link
Member

@GizmoTheMoonPig GizmoTheMoonPig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things I want to address here.

I don't agree with the idea of the golem transformations as it allows you to pacify otherwise hostile mobs. Not a great design idea.

I dont think transformation powder supports chance-based transformations (such as cave spiders turning into either broodlings or swarm spiders) and will just pick whatever is first on the map. In order to support that a bit of rewriting of the data map will be needed. I dont expect you to do this nor do I know if its something I really want to happen so it can be skipped for now.

You also added the hedge spider -> spider transform to datagen again despite it already existing on line 131

@AriaElidove
Copy link

"as it allows you to pacify otherwise hostile mobs."
This already happens by turning hostile wolves into regular wolves, as well as minotaurs into zombified piglins.

I do agree that maybe the Snow Golem <> Stable Ice Core is potentially a bad design, but keep in mind that not every player just carries transformation powder in their back pocket when playing the twilight forest. If anything, this provides a stronger purpose to obtain this powder

@AriaElidove
Copy link

AriaElidove commented Aug 2, 2024

Seeing as #2133 was closed and listed as not planned, this may also need to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants