Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/store_album_cover] 앨범커버 이미지 리소스 변경 로직 #99

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

librarywon
Copy link
Contributor

이슈 코드

📸 스크린샷

🍀 관련 이슈

  • 서버에서 내려주는 앨범커버 번호에 따른 앨범커버 이미지 리소스 변경이 적용
  • loading 추가

@librarywon librarywon added 🦈서재원 서재원이 했다 ✨ Feature 기능 개발 labels Jul 7, 2023
@librarywon librarywon requested a review from a team as a code owner July 7, 2023 06:04
@librarywon librarywon self-assigned this Jul 7, 2023
Comment on lines 34 to 40
val albumCover = when (albumItem.albumCover) {
1 -> R.drawable.ic_album_cover_friends
2 -> R.drawable.ic_album_cover_love
3 -> R.drawable.ic_album_cover_myalbum
4 -> R.drawable.ic_album_cover_collectbook
else -> R.drawable.ic_album_cover_myalbum
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 구현한거 있어 유틸쪽에 구현되어있음

fun Int.toCoverDrawable() = when (this) {
    0 -> R.drawable.ic_album_cover_friends
    1 -> R.drawable.ic_album_cover_love
    2 -> R.drawable.ic_album_cover_myalbum
    3 -> R.drawable.ic_album_cover_collectbook
    else -> throw IllegalArgumentException("Invalid album cover id $this")
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우 감사합니다!!

Copy link
Member

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰만 반영해주고 바로 머지

@librarywon librarywon merged commit a4eb59f into develop Jul 7, 2023
1 check passed
@librarywon librarywon deleted the feature/store_album_cover branch July 7, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🦈서재원 서재원이 했다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature/album_cover] album cover에 따른 이미지 리소스 변경
2 participants