[feature/album detail new]: 앨범 상세 화면 작업 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kez-lab
changed the title
l2hyunwoo
approved these changes
Jul 7, 2023
app/src/main/java/com/teampophory/pophory/data/network/model/album/PhotoListResponse.kt
Show resolved
Hide resolved
| ) : PhotoRepository { | ||
| override suspend fun getPhotos(): Result<PhotoListResponse> { | ||
| return runCatching { retrofitPhotoNetwork.getAlbums() } | ||
| override suspend fun getPhotos(id:Int): Result<PhotoListResponse> { |
app/src/main/java/com/teampophory/pophory/feature/album/detail/AlbumDetailActivity.kt
Outdated
Show resolved
Hide resolved
Comment on lines
69
to
74
| with(viewModel) { | ||
| setPhotoId(photoId) | ||
| setStudio(studio) | ||
| setTakenAt(takenAt) | ||
| setImageUrl(imageUrl) | ||
| } |
There was a problem hiding this comment.
혹시 viewModel에서 가져올거면 savedstatehandle 활용해서 가져오는 것도 고려해보셈
app/src/main/java/com/teampophory/pophory/feature/album/detail/AlbumDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/album/list/AlbumListActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/album/list/AlbumListActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/album/list/AlbumListActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/album/model/PhotoItem.kt
Outdated
Show resolved
Hide resolved
[feat/album_detail]: Add Album Detail [feat/album_detail]: Add Bottom Sheet [feat/album_detail]: bottomSheet 이슈 발생 [feat/album_detail]: AlbumDetailActivity 이동 추가 [feat/album_detail]: AlbumDetail Delete Dialog 추가 [feat/album_detail]: AlbumList refactor and PhotoId Int To Long [feat/album_detail]: AlbumList, Album Detail 세부내용 추가
kez-lab
force-pushed
the
feature/album_detail_new
branch
from
803185b
to
a6d8383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 코드