Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/signup network #96

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Feature/signup network #96

merged 4 commits into from
Jul 7, 2023

Conversation

jihyeonAnAn
Copy link
Contributor

이슈 코드

  • close #

📸 스크린샷

🍀 관련 이슈

@jihyeonAnAn jihyeonAnAn added 🐣 안지현 안지현이 했다 ✨ Feature 기능 개발 labels Jul 7, 2023
@jihyeonAnAn jihyeonAnAn requested a review from a team as a code owner July 7, 2023 04:19
Copy link
Member

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 다시 한번 봐주세영

Comment on lines +69 to +71
val dialog = SignUpDialogFragment()
supportFragmentManager.beginTransaction().add(dialog, "")
.commitAllowingStateLoss()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 서버 API 찌르고 중복할때만 띄우면 될듯

@jihyeonAnAn jihyeonAnAn merged commit 6eb3ab4 into develop Jul 7, 2023
1 check passed
@jihyeonAnAn jihyeonAnAn deleted the feature/signup_network branch July 7, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🐣 안지현 안지현이 했다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants