[Feature/mypage_ui] add VIEW_TYPE_EMPTY #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2hyunwoo
requested changes
Jul 7, 2023
| @@ -103,7 +110,7 @@ class MyPageFragment : Fragment() { | |||
| layoutManager = gridLayoutManager | |||
| adapter = myPageAdapter | |||
| isNestedScrollingEnabled = false | |||
| }.addItemDecoration(GridSpacingItemDecoration(3, 2, false)) | |||
| }.addItemDecoration(GridSpacingCustomDecoration(3, 2, false)) | |||
There was a problem hiding this comment.
Suggested change
| }.addItemDecoration(GridSpacingCustomDecoration(3, 2, false)) | |
| }.addItemDecoration(GridSpacingCustomDecoration(3, 2.dp, false)) |
Comment on lines
23
to
26
| ItemDiffCallback<MyPageDisplayItem>( | ||
| onItemsTheSame = { old, new -> old == new }, | ||
| onContentsTheSame = { old, new -> old == new } | ||
| ) |
kez-lab
approved these changes
Jul 7, 2023
Comment on lines
20
to
27
| class MyPageAdapter( | ||
| private val onItemClicked: (MyPageDisplayItem.Photo) -> Unit | ||
| private val onItemClicked: (MyPageDisplayItem.Photo) -> Unit | ||
| ) : ListAdapter<MyPageDisplayItem, RecyclerView.ViewHolder>( | ||
| ItemDiffCallback<MyPageDisplayItem>( | ||
| onItemsTheSame = { old, new -> old == new }, | ||
| onContentsTheSame = { old, new -> old == new } | ||
| ) | ||
| ItemDiffCallback<MyPageDisplayItem>( | ||
| onItemsTheSame = { old, new -> old == new }, | ||
| onContentsTheSame = { old, new -> old == new } | ||
| ) | ||
| ) { |
l2hyunwoo
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 코드
📸 스크린샷
🍀 관련 이슈
사진이 없을 경우에 fragment xml에 imageView의 visible 속성을 바꾸었습니다.
VIEW_TYPE_EMPTY 뷰 홀더를 adpater에 추가하였습니다.