Feature/signup #88
Merged
Feature/signup #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kez-lab
reviewed
Jul 6, 2023
app/src/main/java/com/teampophory/pophory/feature/signup/SignUpActivity.kt
Outdated
Show resolved
Hide resolved
Comment on lines
42
to
44
| android:layout_marginBottom="22dp" | ||
| app:layout_constraintDimensionRatio="0.75" | ||
| app:layout_constraintBottom_toTopOf="@id/btn_start_social_login" |
Comment on lines
90
to
93
| val text = buildSpannedString { | ||
| append(splittedText[0]) | ||
| color(colorOf(R.color.pophory_purple)) { | ||
| textAppearance(requireContext(), R.style.TextAppearance_Pophory_HeadLineBold) { |
There was a problem hiding this comment.
splittedText.getOrNull(0) 를 사용하면 더 안전할 것 같아요
Comment on lines
+107
to
+111
| private const val HANGUL_PATTERN = "^[a-zA-Z0-9._]{4,12}\$" | ||
| val HANGUL_REGEX: Pattern = Pattern.compile(HANGUL_PATTERN) | ||
|
|
||
| private const val SPECIAL_PATTERN = "^[^._]*$" | ||
| val SPECIAL_REGEX: Pattern = Pattern.compile(SPECIAL_PATTERN) |
Comment on lines
45
to
48
| android:text="@string/start_pophory" | ||
| android:textAppearance="@style/TextAppearance.Pophory.HeadLineSmall" | ||
| android:textSize="17sp" | ||
| android:textColor="@color/pophory_purple" |
There was a problem hiding this comment.
Suggested change
| android:text="@string/start_pophory" | |
| android:textAppearance="@style/TextAppearance.Pophory.HeadLineSmall" | |
| android:textSize="17sp" | |
| android:textColor="@color/pophory_purple" | |
| android:text="@string/start_pophory" | |
| android:textAppearance="@style/TextAppearance.Pophory.HeadLineSmall" | |
| android:textColor="@color/pophory_purple" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 코드
📸 스크린샷
🍀 관련 이슈